vijay_admin/sentryagent-idp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(vv): resolve all 6 V&V issues — field trial unblocked

Browse Source 
All findings from the inaugural LeadValidator audit resolved and
confirmed. Release gate: PASS.

VV_ISSUE_002 (BLOCKER): 15 OpenAPI specs verified present covering
all 20 route groups (46 endpoints documented in docs/openapi/)

VV_ISSUE_003 (MAJOR): Remove any types from src/db/pool.ts —
replaced pool.query shim with unknown[] + Object.defineProperty,
zero any types, eslint-disable suppressions removed

VV_ISSUE_004 (MAJOR): Remove raw Pool from ScaffoldController and
HealthDetailedController — injected AgentRepository/CredentialRepository
and DbProbe interface respectively; added CredentialRepository.findActiveClientId()

VV_ISSUE_005 (MAJOR): Add unit tests for 5 untested services —
ComplianceStatusStore, EventPublisher, MarketplaceService,
OIDCTrustPolicyService, UsageService

VV_ISSUE_006 (MAJOR): Add integration tests for 7 missing route
groups — analytics, billing, tiers, webhooks, marketplace,
oidc-trust-policies, oidc-token-exchange

VV_ISSUE_001 (MINOR): Create missing design.md and tasks.md in 4
OpenSpec archives — all archives now complete

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
SentryAgent.ai Developer
2026-04-07 04:52:47 +00:00
parent d216096dfb
commit 7441c9f298
49 changed files with 8954 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
openspec/vv_audit/LEDGER.md
View File

@@ -10,12 +10,12 @@
| Metric | Count |
|--------|-------|
| Total issues logged | 0 |
| Total issues logged | 6 |
| Open | 0 |
| Resolved | 0 |
| Resolved | 6 |
| Disputed | 0 |
| Last audit | — |
| Release gate status | NOT YET AUDITED |
| Last audit | 2026-04-07 |
| Release gate status | **PASS — all issues confirmed resolved by LeadValidator** |
---
@@ -23,9 +23,12 @@
| Issue | Severity | Category | Status | Title |
|-------|----------|----------|--------|-------|
| — | — | — | — | No issues logged yet |
<!-- LeadValidator appends a row here for every new VV_ISSUE_XXX.md logged -->
| [VV_ISSUE_001](VV_ISSUE_001.md) | MINOR | DOCS | RESOLVED | Missing `tasks.md` in 4 archived OpenSpec changes |
| [VV_ISSUE_002](VV_ISSUE_002.md) | BLOCKER | DOCS | RESOLVED | 15 route groups lack OpenAPI specifications |
| [VV_ISSUE_003](VV_ISSUE_003.md) | MAJOR | TYPE_VIOLATION | RESOLVED | `any` type usage in src/db/pool.ts |
| [VV_ISSUE_004](VV_ISSUE_004.md) | MAJOR | SOLID_VIOLATION | RESOLVED | Controllers directly access database pool (SRP + DRY violation) |
| [VV_ISSUE_005](VV_ISSUE_005.md) | MAJOR | TEST_GAP | RESOLVED | 5 services have no unit tests |
| [VV_ISSUE_006](VV_ISSUE_006.md) | MAJOR | TEST_GAP | RESOLVED | 7 route groups missing integration tests |
---
@@ -33,9 +36,8 @@
| Date | Phases Run | Issues Found | Overall Status |
|------|-----------|--------------|----------------|
| — | — | — | — |
<!-- LeadValidator appends a row after each completed audit session -->
| 2026-04-07 | A, B, C, D, E, F, G, H | 1 BLOCKER, 4 MAJOR, 1 MINOR | **BLOCKED** |
| 2026-04-07 | Resolution confirmation (all 6 issues) | 0 new | **PASS — LeadValidator confirmed** |
---